Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add TxIn #10

Merged
merged 1 commit into from
Sep 16, 2024
Merged

lib: add TxIn #10

merged 1 commit into from
Sep 16, 2024

Conversation

rustaceanrob
Copy link
Contributor

Nothing too wild here. This mirrors what is going on in bdk-ffi and also adds the conversion from TxIn to BitcoinTxIn. Weirdly From<u32> for Sequence is not implemented otherwise this would be super clean.

@reez
Copy link
Collaborator

reez commented Sep 9, 2024

using the try_unwrap, looks good to me!

Good callout on:

Weirdly From<u32> for Sequence is not implemented otherwise this would be super clean.
... that is interesting and would end up looking clean.

@rustaceanrob
Copy link
Contributor Author

rustaceanrob commented Sep 12, 2024 •
edited
Loading

Rebased. I also moved any std imports to be grouped, and any pub reexports to be grouped

@tnull
Copy link
Collaborator

tnull commented Sep 13, 2024 •
edited
Loading

This unfortunately needs another rebase now that #11 landed.

@rustaceanrob
Copy link
Contributor Author

Rebased

@rustaceanrob
Copy link
Contributor Author

Given the conversation on #16, I removed the Arc optimizations in favor of cloning.

thunderbiscuit
thunderbiscuit approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2e3fd74.

I'm not 100% certain yet we should not have the optimization, but I do agree it's worth asking on the uniffi repo and simply adding the optimization to all types that can make use of it once a final decision has been reached. In the meantime this means we can merge those quicker.

@thunderbiscuit thunderbiscuit merged commit 2e3fd74 into bitcoindevkit:master Sep 16, 2024
@rustaceanrob rustaceanrob deleted the txin-08-29 branch September 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rustaceanrob @reez @tnull @thunderbiscuit